Re: First-draft release notes for back branches are up

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: First-draft release notes for back branches are up
Дата
Msg-id 4958.1556982924@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: First-draft release notes for back branches are up  (Andrew Gierth <andrew@tao11.riddles.org.uk>)
Список pgsql-hackers
Andrew Gierth <andrew@tao11.riddles.org.uk> writes:
> "Michael" == Michael Paquier <michael@paquier.xyz> writes:
>  Michael> I have noticed a typo:
>  Michael>        Errors, such as lack of permissions to read the directory, were not
>  Michael>        detected or reported correctly; instead the code silently acted as
>  Michael> -      though the directory were empty.
>  Michael> +      though the directory was empty.

> "as though ... were ..." is correct English; it's a counterfactual
> clause so the subjunctive is appropriate here.

Thanks.  It's been too long since high school English, so I was having
a hard time remembering the correct grammatical term for this; but
I'd just automatically written it that way and was pretty sure it
was right.

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: REINDEX INDEX results in a crash for an index of pg_class since 9.6
Следующее
От: Tom Lane
Дата:
Сообщение: Re: make maintainer-clean and config.cache