Re: [Fwd: Re: [PATCHES] 64-bit CommandIds]

Gregory Stark wrote:
> I don't understand. The patch only affects configuration and SQL data type
> code. It doesn't actually store the 64-bit commandid anywhere which would be
> the actual hard part.

Sure it does, this is the significant part of the patch:

*** pgsql.orig/src/include/c.h    2008-03-02 13:44:45.000000000 +0100
--- pgsql-cid64/src/include/c.h    2008-03-04 21:05:23.000000000 +0100
*************** typedef TransactionId MultiXactId;
*** 382,388 ****
--- 382,392 ----
  typedef uint32 MultiXactOffset;

+ #ifdef USE_64BIT_COMMANDID
+ typedef uint64 CommandId;
+ #else  typedef uint32 CommandId;
+ #endif
  #define FirstCommandId    ((CommandId) 0)

CommandId type is used in htup.h and elsewhere, which changes the 
on-disk format.

--   Heikki Linnakangas  EnterpriseDB   http://www.enterprisedb.com