Magnus Hagander wrote:
> On Wed, Apr 11, 2007 at 02:03:11PM -0400, Andrew Dunstan wrote:
>
>> Peter Eisentraut wrote:
>>
>>> Am Mittwoch, 11. April 2007 17:06 schrieb Andrew Dunstan:
>>>
>>>
>>>> There is a configure time and a runtime check. The code is below - note
>>>> the first #ifdef.
>>>>
>>>>
>>> Yeah, the problem is that the msvc build has no intelligence to detect the
>>> IPv6 APIs to define HAVE_IPV6. So that needs to be developed.
>>>
>>>
>>>
>> The configure test just looks for a definition of struct sockaddr_in6.
>> Taking a quick look It seems to me like this is unconditionally there in
>> the MSVC WS2tcpip.h , so maybe we should just force it for MSVC.
>>
>
> That was my question. I just built with ipv6 enabled using my msvc build on
> my primary machine which does *not* have ipv6, and it still passes
> regression tests fine.
>
> Given that we have a runtime check, is there any reason at all not to
> enable ipv6 on all builds on msvc?
>
> (FWIW, it's been in the platform SDK at least since Windows 2000)
>
>
If we could use configure for MSVC this would have Just Happened (tm). I
wonder how many other little bits we miss out on?
Anyway, the obvious fix seems to be to add a line to
src/tools/msvc/Solution.pm to #define HAVE_IPV6 1 in pg_config.h
cheers
andrew