On 05/12/2018 15:33, Oleksii Kliukin wrote:
>
>> On 30. Nov 2018, at 13:58, Alexander Kukushkin <cyberdemn@gmail.com> wrote:
>>
>> attaching the new version of the patch.
>> Now it simply reserves max_wal_senders slots in the ProcGlobal, what
>> guarantees that only walsender process could use them.
>
> With this patch It looks like InitProcess will trigger the generic error about 'too many clients' before the more
specificerror message in InitWalSenderSlot when exceeding the number of max_wal_senders.
>
> Does excluding WAL senders from the max_connections limit and including max_wal_senders in MaxBackends also imply
thatwe need to add max_wal_senders to the list at xlog.c: CheckRequiredParameterValues, requiring its value on the
replicato be not lower than the one on the primary?
>
I think it does, we need the proc slots for walsenders on the standby
same way we do for normal backends.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services