Re: [pgsql-patches] Patch to avoid gprof profilingoverwrites

Поиск
Список
Период
Сортировка
От Mark Kirkwood
Тема Re: [pgsql-patches] Patch to avoid gprof profilingoverwrites
Дата
Msg-id 45C18039.3050107@paradise.net.nz
обсуждение исходный текст
Ответ на Re: [pgsql-patches] Patch to avoid gprof profilingoverwrites  (<korryd@enterprisedb.com>)
Ответы Re: [pgsql-patches] Patch to avoid gprof profilingoverwrites  (Mark Kirkwood <markir@paradise.net.nz>)
Re: [pgsql-patches] Patch to avoid gprof profilingoverwrites  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-patches
korryd@enterprisedb.com wrote:
>> The name for the define variable could perhaps be better - feels silly
>> adding -DLINUX_PROFILE on Freebsd! (maybe just PROFILE or GPROF_PROFILE?).
>
> That wasn't my choice, there is other code elsewhere that depends on
> that symbol, I just added a little bit more.
>

Right - but LINUX_PROFILE was added to correct Linux specific oddities
with the time counter accumulation, whereas your patch is not Linux
specific at all. So I think a more representative symbol is required.

Cheers

Mark

В списке pgsql-patches по дате отправления:

Предыдущее
От: Bruce Momjian
Дата:
Сообщение: Re: [HACKERS] Typo in pg_dump documentation and new suggestion for Release Notes
Следующее
От: Mark Kirkwood
Дата:
Сообщение: Re: [pgsql-patches] Patch to avoid gprof profilingoverwrites