On 4/7/21 9:50 PM, Andres Freund wrote:
> Hi,
>
> On 2021-04-08 13:33:18 +1200, David Rowley wrote:
>> On Thu, 8 Apr 2021 at 11:06, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> Andres Freund <andres@anarazel.de> writes:
>>>
>>>> Might be force_parallel_mode=regress related.
>>> Yeah. On my machine, it's fine without force_parallel_mode and
>>> crashes with that. Looks like query text is not getting passed
>>> to the parallel worker in some cases.
>> I wonder if it would be worth adding a regression test run of the core
>> tests during make check-world with force_parallel_mode set to regress.
>>
>> But maybe people running the tests on slow machines might not be a fan
>> of that idea.
> I've wondered about that too. Perhaps we could reuse the pg_upgrade run?
>
Honestly I'd prefer it if we could get rid of the rerun of 'make check'
by pg_upgrade's test.sh and instead upgrade the data directory made by
the earlier 'make check' run if it's still there (which would mean we'd
need to stop it being deleted).
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com