missing warning in pg_import_system_collations

Поиск
Список
Период
Сортировка
От Anton Voloshin
Тема missing warning in pg_import_system_collations
Дата
Msg-id 429d64ee-188d-3ce1-106a-53a8b45c4fce@postgrespro.ru
обсуждение исходный текст
Ответы Re: missing warning in pg_import_system_collations  (Ranier Vilela <ranier.vf@gmail.com>)
Re: missing warning in pg_import_system_collations  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
Hello hackers,

In pg_import_system_collations() there is this fragment of code:

enc = pg_get_encoding_from_locale(localebuf, false);
if (enc < 0)
{
    /* error message printed by pg_get_encoding_from_locale() */
    continue;
}

However, false passed to pg_get_encoding_from_locale() means 
write_message argument is false, so no error message is ever printed.
I propose an obvious patch (see attachment).

Introduced in aa17c06fb in January 2017 when debug was replaced by 
false, so I guess back-patching through 10 would be appropriate.

-- 
Anton Voloshin
Postgres Professional, The Russian Postgres Company
https://postgrespro.ru

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Dinesh Chemuduru
Дата:
Сообщение: Re: [PROPOSAL] new diagnostic items for the dynamic sql
Следующее
От: Amit Kapila
Дата:
Сообщение: Re: Added schema level support for publication.