Re: pg_basebackup vs. Windows and tablespaces

<div class="WordSection1"><p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">On 20
December2014 16:30, Amit Kapila Wrote,</span><p class="MsoNormal"><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> </span><pclass="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span><pclass="MsoNormal">>Summarization
oflatest changes:<p class="MsoNormal">>1. Change file name from symlink_label to tablespace_map and changed<p
class="MsoNormal">>thesame every where in comments and variable names.<p class="MsoNormal">>2. This feature will
besupportted for both windows and linux; tablespace_map<p class="MsoNormal">>file will be generated on both windows
andlinux to restore tablespace links<p class="MsoNormal">>during archive recovery.<p class="MsoNormal">>3. 
Handlingfor special characters in tablesapce path name.<br /> >4. Updation of docs.<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span><pclass="MsoNormal"><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">Idid not followed this patch for quite some time, I have
seenall the threads regarding this patch and reviewed from those perspective.</span><p class="MsoNormal"><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> </span><pclass="MsoListParagraph"
style="text-indent:-18.0pt;mso-list:l0level1 lfo1"><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif""><spanstyle="mso-list:Ignore">1.<span style="font:7.0pt
"TimesNew Roman"">     </span></span></span><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">I have
donethe testing and behavior is fine</span><p class="MsoListParagraph" style="text-indent:-18.0pt;mso-list:l0 level1
lfo1"><spanstyle="font-size:10.0pt;font-family:"Tahoma","sans-serif""><span style="mso-list:Ignore">2.<span
style="font:7.0pt"Times New Roman"">     </span></span></span><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">Forhandling special character like new line character, I saw
discussionmostly for two option, </span><p class="MsoListParagraph"
style="margin-left:72.0pt;text-indent:-18.0pt;mso-list:l0level2 lfo1"><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif""><spanstyle="mso-list:Ignore">a.<span style="font:7.0pt
"TimesNew Roman"">     </span></span></span><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">Don’t
supportsuch table space name in tablespace map file and skip those tablespace.</span><p class="MsoListParagraph"
style="margin-left:72.0pt;text-indent:-18.0pt;mso-list:l0level2 lfo1"><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif""><spanstyle="mso-list:Ignore">b.<span style="font:7.0pt
"TimesNew Roman"">     </span></span></span><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">Add ‘\’
characterwhen there is new line in the tablespace name.</span><p class="MsoListParagraph"
style="margin-left:54.0pt"><spanstyle="font-size:10.0pt;font-family:"Tahoma","sans-serif""> </span><p
class="MsoListParagraph"style="margin-left:54.0pt"><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">And
youhave selected option 2, I don’t see any problem in this because it is maintaining human readability, I just want ask
isthis as per the consensus ?</span><p class="MsoListParagraph" style="margin-left:54.0pt"><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> </span><pclass="MsoNormal"><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">Otherthan that patch seems fine to me..</span><p
class="MsoNormal"><spanstyle="font-size:10.0pt;font-family:"Tahoma","sans-serif""> </span><p class="MsoNormal"><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">Regards,</span><pclass="MsoNormal"><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">Dilip</span><pclass="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span></div>