Re: Corrupted btree index on HEAD because of covering indexes

>     I tried to minimize Michael's test case and add it to patch.
> 
> 
> -if (ItemPointerIsValid(leafhikey))
> +if (ItemPointerGetBlockNumberNoCheck(leafhikey) != InvalidBlockNumber)
> 
> Should we use BTreeInnerTupleGetDownLink() as soon as we use
> BTreeInnerTupleSetDownLink() for setting this?
> Or even invent BTreeInnerTupleDownLinkIsValid() macro?
I am not sure. Here we actually store UP link - to top parent to remove. 
I'm afraid using BTreeInnerTupleGetDownLink/BTreeInnerTupleSetDownLink 
could cause a confusion, in other hand, introducing 
TreeInnerTupleGetUpLink/BTreeInnerTupleSetUpLink seems over-engineering

-- 
Teodor Sigaev                      E-mail: teodor@sigaev.ru
                                       WWW: http://www.sigaev.ru/