Re: create tablespace fails silently, or succeeds improperly

Bruce Momjian <bruce@momjian.us> writes:
> Looking at the pg_upgrade code some more, I found that it was not
> removing the PG_VERSION file when deleting <= 8.4 tablespace files. 
> This might confuse administrators so the attached patch adds the removal
> of PG_VERSION.  I would like to apply this to master and 9.0.X.

... why is that a good idea?
        regards, tom lane