Re: DROP DATABASE is interruptible

Поиск
Список
Период
Сортировка
Искать
От
Peter Eisentraut
Тема
Re: DROP DATABASE is interruptible
Дата
Msg-id
3ddf79f2-8b7b-a093-11d2-5c739bc64f86@eisentraut.org
Ответ на
Список
Дерево обсуждения
DROP DATABASE is interruptible Andres Freund <andres@anarazel.de>
Re: DROP DATABASE is interruptible Thomas Munro <thomas.munro@gmail.com>
Re: DROP DATABASE is interruptible Andres Freund <andres@anarazel.de>
Re: DROP DATABASE is interruptible Andres Freund <andres@anarazel.de>
Re: DROP DATABASE is interruptible Andres Freund <andres@anarazel.de>
Re: DROP DATABASE is interruptible Daniel Gustafsson <daniel@yesql.se>
Re: DROP DATABASE is interruptible Andres Freund <andres@anarazel.de>
Re: DROP DATABASE is interruptible Peter Eisentraut <peter@eisentraut.org>
Re: DROP DATABASE is interruptible Andres Freund <andres@anarazel.de>
Re: DROP DATABASE is interruptible Daniel Gustafsson <daniel@yesql.se>
Re: DROP DATABASE is interruptible Andres Freund <andres@anarazel.de>
Re: DROP DATABASE is interruptible Alexander Lakhin <exclusion@gmail.com>
Re: DROP DATABASE is interruptible Thomas Munro <thomas.munro@gmail.com>
Re: DROP DATABASE is interruptible Daniel Gustafsson <daniel@yesql.se>
Re: DROP DATABASE is interruptible Andres Freund <andres@anarazel.de>
Re: DROP DATABASE is interruptible Thomas Munro <thomas.munro@gmail.com>
I noticed that this patch set introduced this pg_dump test:

On 12.07.23 03:59, Andres Freund wrote:
> +	'CREATE DATABASE invalid...' => {
> +		create_order => 1,
> +		create_sql => q(CREATE DATABASE invalid; UPDATE pg_database SET datconnlimit = -2 WHERE datname = 'invalid'),
> +		regexp => qr/^CREATE DATABASE invalid/m,
> +		not_like => {
> +			pg_dumpall_dbprivs => 1,
> +		},
> +	},

But the key "not_like" isn't used for anything by that test suite. 
Maybe "unlike" was meant?  But even then it would be useless because the 
"like" key is empty, so there is nothing that "unlike" can subtract 
from.  Was there something expected from the mention of 
"pg_dumpall_dbprivs"?

Perhaps it would be better to write out

     like => {},

explicitly, with a comment, like some other tests are doing.


В списке pgsql-hackers по дате отправления
От: Michael Paquier
Дата:
От: Michael Paquier
Дата:
FAQ