Hi,
On 4/6/23 4:20 PM, Drouvot, Bertrand wrote:
> Hi,
>
> On 4/6/23 3:39 PM, Amit Kapila wrote:
>> On Thu, Apr 6, 2023 at 6:32 PM Drouvot, Bertrand
>> <bertranddrouvot.pg@gmail.com> wrote:
>>>
>>>
>>> I don't think it could be possible to create logical walsenders on a standby if
>>> AllowCascadeReplication() is not true, or am I missing something?
>>>
>>
>> Right, so why to even traverse walsenders for that case? What I was
>> imagining a code is like:
>> if (AllowCascadeReplication())
>> WalSndWakeup(switchedTLI, true);
>>
>> Do you see any problem with this change?
>
> Not at all, it looks good to me.
>
>>
Done in V63 attached and did change the associated comment a bit.
>> Few more minor comments on 0005
>> =============================
>> 0005
>> 1.
>> + <para>
>> + Take a snapshot of running transactions and write this to WAL without
>> + having to wait bgwriter or checkpointer to log one.
>>
>> /wait bgwriter/wait for bgwriter
>>
>> 2.
>> +use Test::More tests => 67;
>>
>> We no more use the number of tests. Please refer to other similar tests.
>>
>
> Thanks! Will update 0005.
>
Done in V63.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com