On 04.09.23 15:22, Aleksander Alekseev wrote:
> Hi Peter,
>
>> Okay, here we go, starting with:
>>
>> Status summary: Needs review: 227. Waiting on Author: 37. Ready for
>> Committer: 30. Committed: 40. Rejected: 1. Returned with Feedback: 1.
>> Withdrawn: 1. Total: 337.
>>
>> (which is less than CF 2023-07)
>>
>> I have also already applied one round of the waiting-on-author-pruning
>> described below (not included in the above figures).
>
> * Index SLRUs by 64-bit integers rather than by 32-bit integers
> https://commitfest.postgresql.org/44/3489/
>
> The status here was changed to "Needs Review". These patches are in
> good shape and previously were marked as "Ready for Committer".
> Actually I thought Heikki would commit them to PG16, but it didn't
> happen. If there are no objections, I will return the RfC status in a
> bit since it seems to be more appropriate in this case.
The patch was first set to "Ready for Committer" on 2023-03-29, and if I
pull up the thread in the web archive view, that is in the middle of the
page. So as a committer, I would expect that someone would review
whatever happened in the second half of that thread before turning it
over to committer.
As a general rule, if significant additional discussion or patch posting
happens after a patch is set to "Ready for Committer", I'm setting it
back to "Needs review" until someone actually re-reviews it.
I also notice that you are listed as both author and reviewer of that
patch, which I think shouldn't be done. It appears that you are in fact
the author, so I would recommend that you remove yourself from the
reviewers.