Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> [ assorted nits ]
At the level of bikeshedding ... I quite dislike using the name "popcount"
for these functions. I'm aware that some C compilers provide primitives
of that name, but I wouldn't expect a SQL programmer to know that;
without that context the name seems pretty random and unintuitive.
Moreover, it invites confusion with SQL's use of "pop" to abbreviate
"population" in the statistical aggregates, such as var_pop().
Perhaps something along the lines of count_ones() or count_set_bits()
would be more apropos.
regards, tom lane