Re: Generating code for query jumbling through gen_node_support.pl

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Generating code for query jumbling through gen_node_support.pl
Дата
Msg-id 3344827.1675809127@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Generating code for query jumbling through gen_node_support.pl  (Michael Paquier <michael@paquier.xyz>)
Ответы Re: Generating code for query jumbling through gen_node_support.pl  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> With all that in mind, I have spent my day polishing that and doing a
> close lookup, and the patch has been applied.  Thanks a lot!

I have just noticed that this patch is generating useless jumbling
code for node types such as Path nodes and other planner infrastructure
nodes.  That no doubt contributes to the miserable code coverage rating
for queryjumblefuncs.*.c, which have enough dead lines to drag down the
overall rating for all of backend/nodes/.  Shouldn't a little more
attention have been paid to excluding entire node classes if they can
never appear in Query?

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tomas Vondra
Дата:
Сообщение: Re: daitch_mokotoff module
Следующее
От: Tom Lane
Дата:
Сообщение: Re: A bug in make_outerjoininfo