Re: [HACKERS] A mistake in a comment

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: [HACKERS] A mistake in a comment
Дата
Msg-id 29896.1498485244@sss.pgh.pa.us
обсуждение исходный текст
Ответ на [HACKERS] A mistake in a comment  (Victor Drobny <v.drobny@postgrespro.ru>)
Список pgsql-hackers
Victor Drobny <v.drobny@postgrespro.ru> writes:
> I believe that I have found a mistake in a comment to 
> parse_phrase_operator function. The comment has the following line:
> a <X> b (distance is no greater than X)
> which is not. According to documentation and practical results, this 
> line should me changed on something like:
> a <X> b (distance is equal to X)

Ah, this comment got missed when we changed the definition of <N>.

> Patch in the attachments fixes the issue.

Will apply, thanks.  Looks to me like there's an outright bug here
as well: if errno happened to already be ERANGE when we reach the
strtol() call, the code will incorrectly report an error.
        regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Jeevan Ladhe
Дата:
Сообщение: Re: [HACKERS] fix empty array expression in get_qual_for_list()
Следующее
От: Joel Jacobson
Дата:
Сообщение: [HACKERS] \set AUTOROLLBACK ON