Обсуждение: [HACKERS] A mistake in a comment

Поиск
Список
Период
Сортировка

[HACKERS] A mistake in a comment

От
Victor Drobny
Дата:
Hello,

I believe that I have found a mistake in a comment to 
parse_phrase_operator function. The comment has the following line:
a <X> b (distance is no greater than X)
which is not. According to documentation and practical results, this 
line should me changed on something like:
a <X> b (distance is equal to X)

Patch in the attachments fixes the issue.

Thank you for attention!

Best,
Victor
-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Вложения

Re: [HACKERS] A mistake in a comment

От
Tom Lane
Дата:
Victor Drobny <v.drobny@postgrespro.ru> writes:
> I believe that I have found a mistake in a comment to 
> parse_phrase_operator function. The comment has the following line:
> a <X> b (distance is no greater than X)
> which is not. According to documentation and practical results, this 
> line should me changed on something like:
> a <X> b (distance is equal to X)

Ah, this comment got missed when we changed the definition of <N>.

> Patch in the attachments fixes the issue.

Will apply, thanks.  Looks to me like there's an outright bug here
as well: if errno happened to already be ERANGE when we reach the
strtol() call, the code will incorrectly report an error.
        regards, tom lane