Re: qsort vs MSVC build

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: qsort vs MSVC build
Дата
Msg-id 29687.1161280584@sss.pgh.pa.us
обсуждение исходный текст
Ответ на qsort vs MSVC build  ("Magnus Hagander" <mha@sollentuna.net>)
Ответы Re: qsort vs MSVC build  ("Magnus Hagander" <mha@sollentuna.net>)
Re: qsort vs MSVC build  (Martijn van Oosterhout <kleptog@svana.org>)
Re: qsort vs MSVC build  (Neil Conway <neilc@samurai.com>)
Список pgsql-hackers
"Magnus Hagander" <mha@sollentuna.net> writes:
> I just tried a rebuild of the MSVC stuff, and got the following error.
> Any ideas on the best way to fix that?

> 1>.\src\port\qsort.c(53) : warning C4005: 'min' : macro redefinition
>         C:\Program Files\Microsoft Visual Studio

This is fixed already in HEAD.

> MSVCRTD.lib(MSVCR80D.dll) : error LNK2005: _qsort already defined in
> qsort.obj

Hmm.  I've been seeing related complaints on Darwin, but they were just
warnings (about our qsort conflicting with the one in libc).

Is it worth renaming our qsort to pg_qsort to avoid this?  (I'd be
inclined to do that via a macro "#define qsort pg_qsort", not by running
around and changing all the code.)
        regards, tom lane


В списке pgsql-hackers по дате отправления:

Предыдущее
От: "Magnus Hagander"
Дата:
Сообщение: CVS repository rsync
Следующее
От: Tom Lane
Дата:
Сообщение: Re: [PATCHES] Adminpack build fix