Re: [patch] pg_test_timing does not prompt illegal option

Fujii Masao <masao.fujii@gmail.com> writes:
> On Wed, Apr 17, 2019 at 6:21 PM Zhang, Jie <zhangjie2@cn.fujitsu.com> wrote:
>> I think "--" is a illegal option, errors should be prompted.

> This is not the problem only for pg_test_timing. If you want to
> address this, the patch needs to cover all the client commands
> like psql, createuser. I'm not sure if it's worth doing that.

I think it might be an actively bad idea.  There's a pretty
widespread convention that "--" is a no-op switch indicating
the end of switches.  At least some of our tools appear to
honor that behavior (probably because glibc's getopt_long
does; I do not think we are implementing it ourselves).

            regards, tom lane