Re: [BUGS] BUG #5608: array_agg() consumes too much memory

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: [BUGS] BUG #5608: array_agg() consumes too much memory
Дата
Msg-id 29240.1281800986@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: [BUGS] BUG #5608: array_agg() consumes too much memory  (Hitoshi Harada <umi.tanuki@gmail.com>)
Список pgsql-hackers
Hitoshi Harada <umi.tanuki@gmail.com> writes:
> 2010/8/14 Itagaki Takahiro <itagaki.takahiro@gmail.com>:
>> The attached patch is the near-term fix; it adds ALLOCSET_DEFAULT_INITSIZE
>> bytes to memory assumption.
>> 
>> We might need the same adjustment for string_agg(), that consumes
>> 1024 bytes for the transit condition. array_agg() and string_agg()
>> are only aggregates that have "internal" for aggtranstype.

> So, is it better to generalize as it adds ALLOCSET_DEFAULT_INITSIZE if
> the transtype is internal, rather than specifying individual function
> OID as the patch stands?

I've applied a patch following Hitoshi-san's idea.

BTW, a note about the upthread patch: we don't do manual #define's for
OIDs in pg_proc.h.  Use fmgroids.h for that.
        regards, tom lane


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: review: psql: edit function, show function commands patch
Следующее
От: Tom Lane
Дата:
Сообщение: Re: Python 2.7 deprecated the PyCObject API?