On 5/2/16 8:53 AM, Dean Rasheed wrote:
> Here are updated patches doing that --- the first moves
> fmtReloptionsArray() from pg_dump.c to fe_utils/string_utils.c so that
> it can be shared by pg_dump and psql, and renames it to
> appendReloptionsArray(). The second patch fixes the actual psql bug.
This looks reasonable.
I would change appendReloptionsArrayAH() to a function and keep AH as
the first argument (similar to other functions that take such a handle).
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services