Re: pg_upgrade problem with invalid indexes

Bruce Momjian <bruce@momjian.us> writes:
> On Fri, Dec  7, 2012 at 07:49:14PM +0100, Andres Freund wrote:
>> !indislive indexes are created during DROP INDEX CONCURRENTLY. Thats a
>> different case than CREATE INDEX CONCURRENTLY. Accessing their
>> definition is actually problematic because i can vanish while youre
>> examing it which could cause errors both in the backend and in pg_dump.

> Is that something pg_upgrade need to worry about too?  Is
> pg_index.indisvalid the only thing pg_upgrade need to check?

indisvalid should be sufficient.  If you try to test more than that
you're going to make the code more version-specific, without actually
buying much.
        regards, tom lane