Re: Add support for logging the current role

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Add support for logging the current role
Дата
Msg-id 27572.1294851211@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Add support for logging the current role  (Robert Haas <robertmhaas@gmail.com>)
Ответы Re: Add support for logging the current role  (Robert Haas <robertmhaas@gmail.com>)
Re: Add support for logging the current role  (Stephen Frost <sfrost@snowman.net>)
Re: Add support for logging the current role  (Stephen Frost <sfrost@snowman.net>)
Список pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Wed, Jan 12, 2011 at 11:00 AM, Stephen Frost <sfrost@snowman.net> wrote:
>> +1 for whatever the committer wants to commit. ;)

> OK, done.  :-)

Uh, did you actually stop to *think* about this patch?

What you have just committed puts a syscache lookup into the elog output
path.  Quite aside from the likely performance hit, this will
malfunction badly in any case where we're trying to log from an aborted
transaction.

Please revert and rethink.
        regards, tom lane


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Bruce Momjian
Дата:
Сообщение: libpq documentation cleanups (repost 3)
Следующее
От: Robert Haas
Дата:
Сообщение: Re: Add support for logging the current role