Re: Extensions, this time with a patch
| От | Tom Lane |
|---|---|
| Тема | Re: Extensions, this time with a patch |
| Дата | |
| Msg-id | 27158.1287588116@sss.pgh.pa.us обсуждение |
| Ответ на | Re: Extensions, this time with a patch (Dimitri Fontaine <dimitri@2ndQuadrant.fr>) |
| Ответы |
Re: Extensions, this time with a patch
Re: Extensions, this time with a patch Re: Extensions, this time with a patch |
| Список | pgsql-hackers |
Dimitri Fontaine <dimitri@2ndQuadrant.fr> writes:
> Tom Lane <tgl@sss.pgh.pa.us> writes:
>> I don't think that "no changes to the makefiles" is a requirement,
>> or even a wish-list item, for this. I think it's perfectly reasonable
>> for the makefile to have to specify the module name; far better that
>> than that we get the name by some "magic" or other.
> It seemed easy to get a reasonable approach requiring very few edits in
> contribs so I favoured that. Now, it's still entirely possible to hand
> adjust. Determining the extension name automatically from DATA_built or
> DATA is only done where EXTENSION has not been provided,
That is simply a horrid idea. Just make it specify EXTENSION.
> and guessing
> the CONTROL file name from the EXTENSION name only occurs when CONTROL
> has not been provided.
Here, on the other hand, I'm wondering why have two variables at all.
Is there any sane use-case for the control file to not be named the same
as the extension? It seems like that would accomplish little except to
sow confusion.
regards, tom lane
В списке pgsql-hackers по дате отправления: