On 1/10/22, 4:51 AM, "Michael Paquier" <michael@paquier.xyz> wrote:
> The issue comes from an incorrect change in syslogger_parseArgs()
> where I missed that the incrementation of argv by 3 has no need to be
> changed. A build with -DEXEC_BACKEND is enough to show the failure,
> which caused a crash when starting up the syslogger because of a NULL
> pointer dereference. The attached v9 should be enough to switch the
> CF bot to green.
I've been looking at the latest patch set intermittently and playing
around with jsonlog a little. It seems to work well, and I don't have
any significant comments about the code. 0001 and 0002 seem
straightforward and uncontroversial. IIUC 0003 simply introduces
jsonlog using the existing framework.
I wonder if we should consider tracking each log destination as a set
of function pointers. The main logging code would just loop through
the enabled log destinations and use these functions, and it otherwise
would be completely detached (i.e., no "if jsonlog" blocks). This
might open up the ability to define custom log destinations via
modules, too. However, I don't know if there's any real demand for
something like this, and it should probably be done separately from
introducing jsonlog, anyway.
Nathan