Re: Comment on GatherPath.single_copy

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Comment on GatherPath.single_copy
Дата
Msg-id 24467.1472562514@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Comment on GatherPath.single_copy  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
Ответы Re: Comment on GatherPath.single_copy  (Robert Haas <robertmhaas@gmail.com>)
Список pgsql-hackers
Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> writes:
> -    bool        single_copy;    /* path must not be executed >1x */
> +    bool        single_copy;    /* path must not span on multiple processes */

I agree that the existing comment sucks, but this isn't a lot better
(and it will probably not look nice after pgindent gets done with it).
Possibly it's too complicated to jam a reasonable explanation into the
same-line comment, and what is needed is to expand the sentence about
it in the comment above the struct.

Robert, could you fix the documentation for that field so it's
intelligible?
        regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: standalone backend PANICs during recovery
Следующее
От: Tom Lane
Дата:
Сообщение: Re: Missing checks when malloc returns NULL...