Re: Fixes for autocommit = off

Joe Conway <mail@joeconway.com> writes:
> Speaking of autocommit = off, I was contemplating sending in a patch for
> dblink with this in it:
>    appendStringInfo(str,
>                     "BEGIN;SET autocommit='on';COMMIT; %s",
>                      GET_STR(PG_GETARG_TEXT_P(1)));
> (where arg 1 is the user provided sql statement) to cover the non-persistent
> connection case for dblink_exec. Is this the recommended client fix?

You do not need the begin/commit here.

A bigger question is why dblink should be doing that at all... seems
like it should be the programmer's responsibility.

            regards, tom lane