Re: Change GUC hashtable to use simplehash?

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Change GUC hashtable to use simplehash?
Дата
Msg-id 2330615.1700686581@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Change GUC hashtable to use simplehash?  (Andres Freund <andres@anarazel.de>)
Ответы Re: Change GUC hashtable to use simplehash?  (Andres Freund <andres@anarazel.de>)
Список pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> On 2023-11-21 16:42:55 +0700, John Naylor wrote:
>> The strlen call required for hashbytes() is not free. The lack of
>> mixing in the (probably inlined after 0001) previous hash function can
>> remedied directly, as in the attached:

> I doubt this is a good hashfunction. For short strings, sure, but after
> that...  I don't think it makes sense to reduce the internal state of a hash
> function to something this small.

GUC names are just about always short, though, so I'm not sure you've
made your point?  At worst, maybe this with 64-bit state instead of 32?

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: [HACKERS] Changing references of password encryption to hashing
Следующее
От: Heikki Linnakangas
Дата:
Сообщение: Re: psql not responding to SIGINT upon db reconnection