Re: pgsql-server: Add ALTER INDEX, particularly for moving tablespaces.

momjian@svr1.postgresql.org (Bruce Momjian) writes:
> Add ALTER INDEX, particularly for moving tablespaces.

This patch is a perfect example of why unreviewed patches should not
go in during beta.

So far I have noticed the following problems with it:

* Added reference page wasn't linked into the docs build.

* Added a field to struct AlterTableStmt, but did not do the necessary
  housekeeping for extending a Node (eg, copyfuncs and equalfuncs
  adjustments), nor make sure the field is validly set in every place
  an AlterTableStmt is constructed.

* ALTER INDEX RENAME doesn't actually work.

regression=# alter index foo_pkey rename to zzz;
ERROR:  unrecognized rename stmt type: 9

That's not counting the problem someone else already reported with
incorrect tab-completion.

            regards, tom lane