Re: Unnecessary global variable declared in xlog.c

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Unnecessary global variable declared in xlog.c
Дата
Msg-id 2193235.1637046534@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Unnecessary global variable declared in xlog.c  (Michael Paquier <michael@paquier.xyz>)
Ответы Re: Unnecessary global variable declared in xlog.c  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> On Tue, Nov 16, 2021 at 11:17:27AM +0530, Amul Sul wrote:
>> The attached patch moves the "LastRec" variable declaration inside
>> StartupXLOG() where it is supposed to be.

> Yes, reading through the code, your suggestion makes sense.  I'll
> double-check and apply if there are no objections.

I think LastRec was originally referenced by multiple functions
in xlog.c.  But it does look like it could be a local now.

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Masahiko Sawada
Дата:
Сообщение: Re: Skipping logical replication transactions on subscriber side
Следующее
От: Masahiko Sawada
Дата:
Сообщение: Re: Showing I/O timings spent reading/writing temp buffers in EXPLAIN