Re: [PATCHES] zic with msvc

"Magnus Hagander" <mha@sollentuna.net> writes:
>>> + #ifdef WIN32
>>> + #define _WIN32_WINNT 0x0400
>>> + #endif
>>
>> Hmm ... in pg_ctl.c I see
>>
>> #define _WIN32_WINNT 0x0500
>>
>> Is there a reason for these to be different?  Are there other
>> places that will need this (ie, maybe it should be in c.h instead?)

> Not really. The default appears to be 0x0400 for MingW (or it wouldn't
> have worked before), but 0x0350 or so for Visual C++.
> If we define it to 0x0500 we pull in headers that will only work on 2000
> or newer.

Hm.  Actually, if the rest of the backend compiles without this, then
I guess the real question is what's zic.c doing that needs it?  pg_ctl.c
has an excuse because it's doing weird MS-specific junk, but zic.c is
supposed to be bog-standard portable code.  It really shouldn't have
anything that's further out there than you could find in ten other
places in the backend.

            regards, tom lane