Re: Small foreign key error message improvement

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Small foreign key error message improvement
Дата
Msg-id 20649.1246910418@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Small foreign key error message improvement  (Peter Eisentraut <peter_e@gmx.net>)
Ответы Re: Small foreign key error message improvement  (Peter Eisentraut <peter_e@gmx.net>)
Список pgsql-hackers
Peter Eisentraut <peter_e@gmx.net> writes:
> I recently had a puzzler, which involved this sort of accidental parser error:
> CREATE TABLE foo (a int, b text, PRIMARY KEY (a, b));

> CREATE TABLE bar (x int, y text, FOREIGN KEY (q, r) REFERENCES foo (m, n));
> ERROR:  column "q" referenced in foreign key constraint does not exist

> versus

> CREATE TABLE bar (x int, y text, FOREIGN KEY (x, y) REFERENCES foo (m, n));
> ERROR:  column "m" referenced in foreign key constraint does not exist

> This example has been simplified for clarity, but the original case involved a 
> bunch of "id" columns everywhere.  What's confusing is that "q" is not 
> actually referenced by the foreign key constraint, but referenced in the 
> statement that attempts to define the foreign key constraint, so I was looking 
> on the wrong side of the constraint there.

> Attached is a small patch that separates those error messages into:

It seems to me that the right fix here is not so much to tweak the
message wording as to put in an error location cursor.  In more
complicated cases (eg, multiple FOREIGN KEY clauses) the suggested
wording change wouldn't help much anyway.
        regards, tom lane


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Stefan Kaltenbrunner
Дата:
Сообщение: Re: please, actualize czech link on international sites list
Следующее
От: Bernd Helmle
Дата:
Сообщение: Re: TODO items: Alter view add column