Re: Add backup_type to pg_stat_progress_basebackup

On Tue, 22 Jul 2025 17:48:35 +0900
Shinya Kato <shinya11.kato@gmail.com> wrote:

> Hi hackers,
> 
> Starting with PostgreSQL 17, pg_basebackup supports incremental
> backups. However, the pg_stat_progress_basebackup view doesn't
> currently show the backup type (i.e., whether it's a full or
> incremental backup).
> 
> Therefore, I propose adding a backup_type column to this view. While
> this information is available in pg_stat_activity, the backup type is
> important for monitoring the progress of pg_basebackup, and including
> it directly in the progress view would be very useful.
> 
> Thoughts?

That seems reasonable to me.

Just one minor comment on the patch:

+
+     <row>
+      <entry role="catalog_table_entry"><para role="column_definition">
+       <structfield>backup_type</structfield> <type>bigint</type>
+      </para>
+      <para>
+        Backup type. Either <literal>full</literal> or
+        <literal>incremental</literal>.
+      </para></entry>
+     </row>

The type should be text rather than bigint.

Regards,
Yugo Nagata

-- 
Yugo Nagata <nagata@sraoss.co.jp>