Re: Call pqPipelineFlush from PQsendFlushRequest

Поиск
Список
Период
Сортировка
От Alvaro Herrera
Тема Re: Call pqPipelineFlush from PQsendFlushRequest
Дата
Msg-id 202311081610.xvceobshgs2j@alvherre.pgsql
обсуждение исходный текст
Ответ на Re: Call pqPipelineFlush from PQsendFlushRequest  (Michael Paquier <michael@paquier.xyz>)
Ответы Re: Call pqPipelineFlush from PQsendFlushRequest  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
On 2023-Nov-07, Michael Paquier wrote:

> On Tue, Nov 07, 2023 at 10:38:04AM +0100, Jelte Fennema-Nio wrote:
> > In pipeline mode after queuing a message to be sent we would flush the
> > buffer if the size of the buffer passed some threshold. The only message
> > type that we didn't do that for was the Flush message. This addresses
> > that oversight.
> > 
> > I noticed this discrepancy while reviewing the
> > PQsendSyncMessage/PQpipelinePutSync patchset.
> 
> Indeed, it looks a bit strange that there is no flush if the buffer
> threshold is reached once the message is sent, so your suggestion
> sounds right.  Alvaro?

Pushed, thanks.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"Porque Kim no hacía nada, pero, eso sí,
con extraordinario éxito" ("Kim", Kipling)



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: 64-bit integer subtraction bug on some platforms
Следующее
От: Alvaro Herrera
Дата:
Сообщение: Re: Add PQsendSyncMessage() to libpq