Re: Improve logging when using Huge Pages

On Mon, Feb 13, 2023 at 05:22:45PM -0600, Justin Pryzby wrote:
> +        Reports whether huge pages are in use by the current process.
> +        See <xref linkend="guc-huge-pages"/> for more information.

nitpick: Should this say "server" instead of "current process"?

> +static char *huge_pages_active = "unknown"; /* dynamically set */

nitpick: Does this need to be initialized here?

> +    {
> +        {"huge_pages_active", PGC_INTERNAL, PRESET_OPTIONS,
> +            gettext_noop("Indicates whether huge pages are in use."),
> +            NULL,
> +            GUC_NOT_IN_SAMPLE | GUC_DISALLOW_IN_FILE | GUC_RUNTIME_COMPUTED
> +        },
> +        &huge_pages_active,
> +        "unknown",
> +        NULL, NULL, NULL
> +    },

I'm curious why you chose to make this a string instead of an enum.  There
might be little practical difference, but since there are only three
possible values, I wonder if it'd be better form to make it an enum.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com