Re: Improve logging when using Huge Pages

Поиск
Список
Период
Сортировка
От Justin Pryzby
Тема Re: Improve logging when using Huge Pages
Дата
Msg-id 20230213232245.GI1653@telsasoft.com
обсуждение исходный текст
Ответ на Re: Improve logging when using Huge Pages  (Nathan Bossart <nathandbossart@gmail.com>)
Ответы Re: Improve logging when using Huge Pages  (Nathan Bossart <nathandbossart@gmail.com>)
Список pgsql-hackers
On Thu, Feb 09, 2023 at 11:29:09AM -0800, Nathan Bossart wrote:
> On Thu, Feb 09, 2023 at 10:40:13AM +0100, Alvaro Herrera wrote:
> > On 2023-Feb-08, Justin Pryzby wrote:
> >> I don't think it makes sense to run postgres -C huge_pages_active,
> >> however, so I see no issue that that would always returns "false".
> > 
> > Hmm, I would initialize it to return "unknown" rather than "off" — and
> > make sure it turns "off" at the appropriate time.  Otherwise you're just
> > moving the confusion elsewhere.
> 
> I think this approach would address my concerns about using a GUC.

Done that way.  This also fixes the logic in win32_shmem.c.

-- 
Justin

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Jacob Champion
Дата:
Сообщение: [PATCH] Fix unbounded authentication exchanges during PQconnectPoll()
Следующее
От: Andres Freund
Дата:
Сообщение: Re: recovery modules