Re: test/modules/test_oat_hooks vs. debug_discard_caches=1

Поиск
Список
Период
Сортировка
От Andres Freund
Тема Re: test/modules/test_oat_hooks vs. debug_discard_caches=1
Дата
Msg-id 20221119003349.uzpopxq2skgrmwc4@awork3.anarazel.de
обсуждение исходный текст
Ответ на test/modules/test_oat_hooks vs. debug_discard_caches=1  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: test/modules/test_oat_hooks vs. debug_discard_caches=1  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: test/modules/test_oat_hooks vs. debug_discard_caches=1  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
Hi,

On 2022-11-18 15:55:34 -0500, Tom Lane wrote:
> We realized today [1] that it's been some time since the buildfarm
> had any debug_discard_caches (nee CLOBBER_CACHE_ALWAYS) coverage.

Do we know when it was covered last? I assume it's before the addition of
test_oat_hooks in 90efa2f5565?


> Sure enough, as soon as Tomas turned that back on, kaboom [2].
> The test_oat_hooks test is failing --- it's not crashing, but
> it's emitting more NOTICE lines than the expected output includes,
> evidently as a result of the hooks getting invoked extra times
> during cache reloads.  I can reproduce that here.

Did you already look into where those additional namespace searches are coming
from? There are case in which it is not unproblematic to have repeated
namespace searches due to the potential for races it opens up...

Greetings,

Andres Freund



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: Allow placeholders in ALTER ROLE w/o superuser
Следующее
От: Alexander Korotkov
Дата:
Сообщение: Re: Allow placeholders in ALTER ROLE w/o superuser