On Thu, Sep 08, 2022 at 05:55:40PM +0900, Michael Paquier wrote:
> On Tue, Aug 30, 2022 at 01:29:24PM +1200, Thomas Munro wrote:
> > This reminds me of 24c3ce8f1, which replaced a dlopen()-ish thing with
> > a direct function call. Can you just call all these functions
> > directly these days?
>
> Hmm. Some tests in the CI show that attempting to call directly
> MiniDumpWriteDump() causes a linking failure at compilation. Anyway,
> in the same fashion, I can get some simplifications done right for
> pg_ctl.c, auth.c and restricted_token.c. And I am seeing all these
> functions listed in the headers of MinGW, meaning that all these
> should work out of the box in this case, no?
>
> The others are library-dependent, and I not really confident about
> ldap_start_tls_sA(). So, at the end, I am finishing with the
> attached, what do you think? This cuts some code, which is nice:
> 3 files changed, 48 insertions(+), 159 deletions(-)
+1
It seems silly to do it at runtime if it's possible to do it at link time.
--
Justin