On Wed, Jul 06, 2022 at 08:25:04AM -0400, Robert Haas wrote:
> On Wed, Jul 6, 2022 at 7:56 AM Justin Pryzby <pryzby@telsasoft.com> wrote:
> > I'm looking into it, but it'd help to hear suggestions about where to put it.
> > My current ideas aren't very good.
>
> In main() there is a comment that begins "Most failures happen in
> create_new_objects(), which has just completed at this point." I am
> thinking you might want to insert a new function call just before that
> comment, like remove_orphaned_files() or tidy_up_new_cluster().
>
> Another option could be to do something at the beginning of
> transfer_all_new_tablespaces().
That seems like the better option, since it has access to the custer's
filenodes.
I checked upgrades from 9.2, upgrades with/out vacuum full, and upgrades with a
DB tablespace.
Maybe it's a good idea to check that the file is empty before unlinking...
--
Justin