On Thu, Jan 09, 2020 at 10:28:21AM +0100, Fabien COELHO wrote:
> Yep, I thought of it, but I was not very keen on having a malloc/free cycle
> just for one debug message. However under debug this is probably not an
> issue.
Consistency is more important here IMO, so applied.
> Your patch works for me. IT can avoid some level of format interpretation
> overheads by switching to Char/Str functions, see first attachement.
I kept both grouped to avoid any unnecessary churn with the
manipulation of PQExpBufferData.
> The other point is the test on __pg_log_level, see second attached.
May be better to discuss that on a separate thread as that's not only
related to pgbench.
--
Michael