RE: Proposal: Add more compile-time asserts to exposeinconsistencies.

Поиск
Список
Период
Сортировка
Искать
От
Smith, Peter
Тема
RE: Proposal: Add more compile-time asserts to exposeinconsistencies.
Дата
Msg-id
201DD0641B056142AC8C6645EC1B5F62014B9C3649@SYD1217
Ответ на
Список
Дерево обсуждения
Proposal: Add more compile-time asserts to expose inconsistencies. "Smith, Peter" <peters@fast.au.fujitsu.com>
Re: Proposal: Add more compile-time asserts to exposeinconsistencies. Michael Paquier <michael@paquier.xyz>
RE: Proposal: Add more compile-time asserts to exposeinconsistencies. "Smith, Peter" <peters@fast.au.fujitsu.com>
Re: Proposal: Add more compile-time asserts to expose inconsistencies. ilmari@ilmari.org (Dagfinn Ilmari Mannsåker)
Re: Proposal: Add more compile-time asserts to exposeinconsistencies. Michael Paquier <michael@paquier.xyz>
Re: Proposal: Add more compile-time asserts to exposeinconsistencies. Kyotaro Horiguchi <horikyota.ntt@gmail.com>
RE: Proposal: Add more compile-time asserts to exposeinconsistencies. "Smith, Peter" <peters@fast.au.fujitsu.com>
Re: Proposal: Add more compile-time asserts to exposeinconsistencies. Andres Freund <andres@anarazel.de>
Re: Proposal: Add more compile-time asserts to expose inconsistencies. Tom Lane <tgl@sss.pgh.pa.us>
Re: Proposal: Add more compile-time asserts to expose inconsistencies. Andres Freund <andres@anarazel.de>
RE: Proposal: Add more compile-time asserts to exposeinconsistencies. "Smith, Peter" <peters@fast.au.fujitsu.com>
Re: Proposal: Add more compile-time asserts to exposeinconsistencies. Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Re: Proposal: Add more compile-time asserts to expose inconsistencies. Andres Freund <andres@anarazel.de>
RE: Proposal: Add more compile-time asserts to exposeinconsistencies. "Smith, Peter" <peters@fast.au.fujitsu.com>
Re: Proposal: Add more compile-time asserts to exposeinconsistencies. Andres Freund <andres@anarazel.de>
RE: Proposal: Add more compile-time asserts to exposeinconsistencies. "Smith, Peter" <peters@fast.au.fujitsu.com>
Re: Proposal: Add more compile-time asserts to exposeinconsistencies. Kyotaro Horiguchi <horikyota.ntt@gmail.com>
RE: Proposal: Add more compile-time asserts to exposeinconsistencies. "Smith, Peter" <peters@fast.au.fujitsu.com>
Re: Proposal: Add more compile-time asserts to exposeinconsistencies. Michael Paquier <michael@paquier.xyz>
RE: Proposal: Add more compile-time asserts to exposeinconsistencies. "Smith, Peter" <peters@fast.au.fujitsu.com>
Re: Proposal: Add more compile-time asserts to exposeinconsistencies. Michael Paquier <michael@paquier.xyz>
Re: Proposal: Add more compile-time asserts to exposeinconsistencies. Andres Freund <andres@anarazel.de>
Re: Proposal: Add more compile-time asserts to exposeinconsistencies. Michael Paquier <michael@paquier.xyz>
Re: Proposal: Add more compile-time asserts to exposeinconsistencies. Andres Freund <andres@anarazel.de>
RE: Proposal: Add more compile-time asserts to exposeinconsistencies. "Smith, Peter" <peters@fast.au.fujitsu.com>
Re: Proposal: Add more compile-time asserts to exposeinconsistencies. Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Re: Proposal: Add more compile-time asserts to exposeinconsistencies. Andres Freund <andres@anarazel.de>
Re: Proposal: Add more compile-time asserts to exposeinconsistencies. Michael Paquier <michael@paquier.xyz>
RE: Proposal: Add more compile-time asserts to exposeinconsistencies. "Smith, Peter" <peters@fast.au.fujitsu.com>
Re: Proposal: Add more compile-time asserts to exposeinconsistencies. Michael Paquier <michael@paquier.xyz>
Re: Proposal: Add more compile-time asserts to exposeinconsistencies. Michael Paquier <michael@paquier.xyz>
Re: Proposal: Add more compile-time asserts to exposeinconsistencies. Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Re: Proposal: Add more compile-time asserts to exposeinconsistencies. Michael Paquier <michael@paquier.xyz>
Re: Proposal: Add more compile-time asserts to exposeinconsistencies. Michael Paquier <michael@paquier.xyz>
RE: Proposal: Add more compile-time asserts to exposeinconsistencies. "Smith, Peter" <peters@fast.au.fujitsu.com>
Re: Proposal: Add more compile-time asserts to exposeinconsistencies. Michael Paquier <michael@paquier.xyz>
Re: Proposal: Add more compile-time asserts to exposeinconsistencies. Andres Freund <andres@anarazel.de>
Re: Proposal: Add more compile-time asserts to exposeinconsistencies. Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
RE: Proposal: Add more compile-time asserts to exposeinconsistencies. "Smith, Peter" <peters@fast.au.fujitsu.com>
Re: Proposal: Add more compile-time asserts to exposeinconsistencies. Andres Freund <andres@anarazel.de>
RE: Proposal: Add more compile-time asserts to exposeinconsistencies. "Smith, Peter" <peters@fast.au.fujitsu.com>
> It seems to me that there is a good point to be consistent with the treatment of StaticAssertStmt and StaticAssertExpr in c.h, which have fallback implementations in *all* the configurations supported.

Consistency is good, but:

* That is beyond the scope for what I wanted my patch to achieve; my use-cases are C code only

* It is too risky for me to simply cut/paste my C version of StaticAssertDecl and hope it will work OK for C++. It needs lots of testing because there seems evidence that bad things can happen. E.g. Peter Eisentraut wrote "if you're asking, why is the fallback implementation in C++ different from the one in C, then that's because the C variant didn't work in C++."

~

I am happy if somebody else with more ability to test C++ properly wants to add the __cplusplus variant of the new macro.

Meanwhile, I've attached latest re-based version of this patch.

Kind Regards.
--
Peter Smith
Fujitsu Australia
В списке pgsql-hackers по дате отправления
От: Rafia Sabih
Дата:
От: Amit Kapila
Дата:
FAQ