On Mon, Nov 04, 2019 at 10:44:53AM -0800, Andres Freund wrote:
>Hi,
>
>On 2019-11-04 19:39:18 +0100, Tomas Vondra wrote:
>> On Mon, Nov 04, 2019 at 10:04:09AM -0800, Andres Freund wrote:
>> > And "without causing significant issues elsewhere" unfortunately
>> > includes continuing to allow pg_upgrade to work.
>
>> Yeah. I suppose we could have a different AM implementing this, but
>> maybe that's not possible ...
>
>Entirely possible. But the amount of code duplication / unnecessary
>branching and the user confusion from two very similar AMs, would have
>to be weighed against the benefits.
>
Agreed. I think code complexity is part of the trade-off. IMO it's fine
to hack existing heap AM initially, and only explore the separate AM if
that turns out to be promising.
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services