On Mon, Jul 29, 2019 at 11:30:53AM +0200, Peter Eisentraut wrote:
> Another patch, with various fallback implementations.
I have spotted some issues with this patch:
1) The list of port files @pgportfiles in Mkvcbuild.pm has not been
updated with the new file explicit_bzero.c, so the compilation would
fail with MSVC.
2) pg_config.h.win32 does not include the two new flags (same as
https://www.postgresql.org/message-id/20190624050850.GE1637@paquier.xyz)
3) What about CreateRole() and AlterRole() which can manipulate a
password in plain format before hashing? (same message as previous
point).
Nit: src/port/explicit_bzero.c misses its IDENTIFICATION tag.
--
Michael