Re: check_recovery_target_lsn() does a PG_CATCH without a throw

Поиск
Список
Период
Сортировка
Искать
От
Michael Paquier
Тема
Re: check_recovery_target_lsn() does a PG_CATCH without a throw
Дата
Msg-id
20190630123552.GB2286@paquier.xyz
Ответ на
Re: check_recovery_target_lsn() does a PG_CATCH without a throw (Peter Eisentraut)
Список
Дерево обсуждения
check_recovery_target_lsn() does a PG_CATCH without a throw Andres Freund <andres@anarazel.de>
Re: check_recovery_target_lsn() does a PG_CATCH without a throw Sergei Kornilov <sk@zsrv.org>
Re: check_recovery_target_lsn() does a PG_CATCH without a throw Tom Lane <tgl@sss.pgh.pa.us>
Re: check_recovery_target_lsn() does a PG_CATCH without a throw Andres Freund <andres@anarazel.de>
Re: check_recovery_target_lsn() does a PG_CATCH without a throw Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Re: check_recovery_target_lsn() does a PG_CATCH without a throw Michael Paquier <michael@paquier.xyz>
Re: check_recovery_target_lsn() does a PG_CATCH without a throw Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Re: check_recovery_target_lsn() does a PG_CATCH without a throw Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Re: check_recovery_target_lsn() does a PG_CATCH without a throw Andres Freund <andres@anarazel.de>
Re: check_recovery_target_lsn() does a PG_CATCH without a throw Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Re: check_recovery_target_lsn() does a PG_CATCH without a throw Michael Paquier <michael@paquier.xyz>
Re: check_recovery_target_lsn() does a PG_CATCH without a throw Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Re: check_recovery_target_lsn() does a PG_CATCH without a throw Michael Paquier <michael@paquier.xyz>
Re: check_recovery_target_lsn() does a PG_CATCH without a throw Michael Paquier <michael@paquier.xyz>
Re: check_recovery_target_lsn() does a PG_CATCH without a throw Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Re: check_recovery_target_lsn() does a PG_CATCH without a throw Michael Paquier <michael@paquier.xyz> 
On Sun, Jun 30, 2019 at 11:06:58AM +0200, Peter Eisentraut wrote:
> I ended up rewriting this by extracting the parsing code into
> pg_lsn_in_internal() and having both pg_lsn_in() and
> check_recovery_target_lsn() calling it.  This mirrors similar
> arrangements in float.c

The refactoring looks good to me (including what you have just fixed
with PG_RETURN_LSN).  Thanks for considering it.
--
Michael
В списке pgsql-hackers по дате отправления
Предыдущее
От: Julien Rouhaud
Дата:
Следующее
От: Alexander Lakhin
Дата:
FAQ