Re: check_recovery_target_lsn() does a PG_CATCH without a throw

On 2019-06-24 06:06, Michael Paquier wrote:
> -       if (strcmp(*newval, "epoch") == 0 ||
> -           strcmp(*newval, "infinity") == 0 ||
> -           strcmp(*newval, "-infinity") == 0 ||
> Why do you remove these?  They should still be rejected because they
> make no sense as recovery targets, no?

Yeah but the new code already rejects those anyway.  Note how
timestamptz_in() has explicit switch cases to accept those, and we
didn't carry those over into check_recovery_time().

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services