Re: tableam: inconsistent parameter name

Поиск
Список
Период
Сортировка
От Andres Freund
Тема Re: tableam: inconsistent parameter name
Дата
Msg-id 20190607165229.z5hp7omlzymtytts@alap3.anarazel.de
обсуждение исходный текст
Ответ на tableam: inconsistent parameter name  (Robert Haas <robertmhaas@gmail.com>)
Ответы Re: tableam: inconsistent parameter name  (Robert Haas <robertmhaas@gmail.com>)
Список pgsql-hackers
Hi,

On 2019-06-07 12:37:33 -0400, Robert Haas wrote:
> TableAmRoutine's index_build_range_scan thinks that parameter #8 is
> called end_blockno, but table_index_build_range_scan and
> heapam_index_build_range_scan and BRIN's summarize_range all agree
> that it's the number of blocks to be scanned.  I assume that this got
> changed at some point while Andres was hacking on it and this one
> place just never got updated.

Not sure where it came from :/

> Proposed patch attached.  Since this seems like a bug, albeit a
> harmless one, I propose to commit this to v12.

Yea, please do!

Greetings,

Andres Freund



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: Custom table AMs need to include heapam.h because ofBulkInsertState
Следующее
От: Robert Haas
Дата:
Сообщение: Re: tableam: inconsistent parameter name