Hi,
On 2019-05-17 14:49:19 -0700, Ashwin Agrawal wrote:
> On Fri, May 17, 2019 at 12:54 PM Andres Freund <andres@anarazel.de> wrote:
>
> > Hi,
> >
> > On 2019-05-15 23:00:38 -0700, Ashwin Agrawal wrote:
> > > Highlevel this looks good to me. Will look into full details tomorrow.
> >
> > Ping?
> >
> > I'll push the first of the patches soon, and unless you'll comment on
> > the second soon, I'll also push ahead. There's a beta upcoming...
> >
>
> Sorry for the delay, didn't get to it yesterday. Looked into both the
> patches. They both look good to me, thank you.
Pushed both now.
> Relation size API still doesn't address the analyze case as you mentioned
> but sure something we can improve on later.
I'm much less concerned about that. You can just return a reasonable
block size from the size callback, and it'll work for block sampling
(and you can just skip pages in the analyze callback if needed, e.g. for
zheap's tpd pages). And we assume that a reasonable block size is
returned by the size callback anyway, for planning purposes (both in
relpages and for estimate_rel_size). We'll probably want to improve
that some day, but it doesn't strike me as hugely urgent.
Greetings,
Andres Freund