On Sat, Apr 27, 2019 at 10:38:50PM +0200, Fabien COELHO wrote:
>
> Hello David,
>
> Patch applies. There seems to be a compilation issue:
>
> describe.c:5974:1: error: expected declaration or statement at end of
> input
> }
This is in brown paper bag territory. Fixed.
> > I think the way forward is to test this with TAP rather than the
> > fixed-string method.
>
> Ok.
I've sent a separate patch extracted from the one you sent which adds
stdin to our TAP testing infrastructure. I hope it lands so it'll be
simpler to add these tests in a future version of the patch.
> > Checks removed while I figure out a new TAP test.
>
> > > I only have packages down to pg 9.3, so I could not test prior 9.1.
> > > By looking at the online documentation, is seems that relistemp
> > > appears in pg 8.4, so the corresponding extraction should be guarded
> > > by this version. Before that, temporary objects existed but were
> > > identified indirectly, possibly because they were stored in a
> > > temporary schema. I suggest not to try to address cases prior 8.4.
> >
> > Done.
>
> After some checking, I think that there is an issue with the version
> numbers:
> - 9.1 is 90100, not 91000
> - 8.4 is 80400, not 84000
Another brown paper bag, now fixed.
> Also, it seems that describes builds queries with uppercase
> keywords, so probably the new additions should follow that style:
> case -> CASE (and also when then else end as…)
Done.
Best,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778
Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate