Re: pgsql: Add support for collation attributes on older ICU versions

Поиск
Список
Период
Сортировка
От Andres Freund
Тема Re: pgsql: Add support for collation attributes on older ICU versions
Дата
Msg-id 20190319153204.ske4achkx7zsok5u@alap3.anarazel.de
обсуждение исходный текст
Ответ на Re: pgsql: Add support for collation attributes on older ICU versions  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Список pgsql-committers
Дерево обсуждения 
On 2019-03-19 09:49:14 +0100, Peter Eisentraut wrote:
> On 2019-03-18 20:03, Andres Freund wrote:
> > I now get this warning:
> > 
> > /home/andres/src/postgresql/src/backend/utils/adt/pg_locale.c:1680:14: warning: comparison of constant -1 with
expressionof type 'UColAttribute' is always true [-Wtautological-constant-out-of-range-compare]
 
> >                         if (uattr != -1 && uvalue != -1)
> >                             ~~~~~ ^  ~~
> 
> I found a bug in that code and restructured it a bit.  It should also
> avoid this warning now.

Thanks.

В списке pgsql-committers по дате отправления:

Предыдущее
От: Alvaro Herrera
Дата:
Сообщение: Re: pgsql: Revise parse tree representation for VACUUM and ANALYZE.
Следующее
От: Tom Lane
Дата:
Сообщение: pgsql: Make checkpoint requests more robust.