Re: get_controlfile() can leak fds in the backend

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: get_controlfile() can leak fds in the backend
Дата
Msg-id 20190228005445.GC1617@paquier.xyz
обсуждение исходный текст
Ответ на Re: get_controlfile() can leak fds in the backend  (Joe Conway <mail@joeconway.com>)
Ответы Re: get_controlfile() can leak fds in the backend  (Joe Conway <mail@joeconway.com>)
Список pgsql-hackers
Дерево обсуждения 
On Wed, Feb 27, 2019 at 07:45:11PM -0500, Joe Conway wrote:
> It seems to me that OpenTransientFile() is more appropriate. Patch done
> that way attached.

Works for me, thanks for sending a patch!  While on it, could you
clean up the comment on top of get_controlfile()?  "char" is mentioned
instead of "const char" for DataDir which is incorrect.  I would
remove the complete set of arguments from the description and just
keep the routine name.
--
Michael
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: get_controlfile() can leak fds in the backend
Следующее
От: Marc Dean
Дата:
Сообщение: Re: BUG #15293: Stored Procedure Triggered by Logical Replication isUnable to use Notification Events